Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

Stream manager #114

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Stream manager #114

merged 10 commits into from
Feb 27, 2024

Conversation

Djadih
Copy link

@Djadih Djadih commented Feb 27, 2024

Fixes many issues, new features are:

  • Persist a stream between peers to minimize resource use
  • Implement a new request/response envelope to simplify message handling and eliminate handler redundancies
  • Simplify logic to decode and encode responses/requests
  • Various other process simplifications/improvements

@Djadih Djadih added the enhancement New feature or request label Feb 27, 2024
@Djadih Djadih added this to the Golden Age Testnet milestone Feb 27, 2024
@Djadih Djadih self-assigned this Feb 27, 2024
@Djadih
Copy link
Author

Djadih commented Feb 27, 2024

First two commits are necessary bugfixes from @gameofpointers

@Djadih Djadih marked this pull request as ready for review February 27, 2024 18:53
Copy link

@alejoacosta74 alejoacosta74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing and left a couple of questions.
@gameofpointers or @wizeguyy can you also take a look?

common/stream_services.go Show resolved Hide resolved
p2p/pb/quai_messages.proto Show resolved Hide resolved
@Djadih Djadih merged commit 57c32e7 into dominant-strategies:main Feb 27, 2024
6 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants